Use prop "helmetKey" if it's present as primary attribute. #282
Conversation
This allows more fine-grained control over which tags are duplicated vs overwritten. Tags of the same type with the same value in "helmetKey" will be overwritten, even if the would normally be duplicated. Tags of the same type with different values in "helmetKey" will be duplicated, even if they would normally be overwritten.
|
|
|
Provides a way to solve #103 |
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
==========================================
+ Coverage 97.59% 98.22% +0.62%
==========================================
Files 3 3
Lines 291 281 -10
==========================================
- Hits 284 276 -8
+ Misses 7 5 -2
Continue to review full report at Codecov.
|
|
@cwelch5 We need this feature too. Please accept this pull request. |
|
What's the status of this PR? I think I can help to resolve the current conflicts in |
|
Can I help something for resolve problems? |
|
Is this a dead project? |
|
@mrkam2 Nope, trying to get some help in managing it. Sorry we've been a bit unresponsive. |
| // Special rule for 'key' prop, which takes over the normal priority mechanism | ||
| if (attributeKey === TAG_PROPERTIES.KEY) { | ||
| primaryAttributeKey = attributeKey; | ||
| break; |
There was a problem hiding this comment.
getting Unsemantic break errors on this line.
|
@emilecantin @haxxxton @alex-karo Would love to see this fixed and merged 👍 This makes it way easier to do dynamic favicon updates. |
|
Any updates on it? |
This allows more fine-grained control over which tags are duplicated vs
overwritten.