Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fixes, tests for #282 using helmetKey #455

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adewey
Copy link

@adewey adewey commented May 17, 2019

This is a re-implementation of #282 which has been inactive for some time without response. Below is the original PR comment. The code was moved to the correct location and test written to verify.

This allows more fine-grained control over which tags are duplicated vs
overwritten.

  • Tags of the same type with the same value in "helmetKey" will be overwritten, even if the would normally be duplicated.
  • Tags of the same type with different values in "helmetKey" will be duplicated, even if they would normally be overwritten.

Aaron Dewey added 2 commits May 9, 2019 14:12
@CLAassistant
Copy link

CLAassistant commented May 17, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Aaron Dewey seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #455 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
+ Coverage    97.6%   97.62%   +0.02%     
==========================================
  Files           3        3              
  Lines         292      295       +3     
==========================================
+ Hits          285      288       +3     
  Misses          7        7
Impacted Files Coverage Δ
src/HelmetConstants.js 100% <ø> (ø) ⬆️
src/HelmetUtils.js 96.91% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 420810c...5978e02. Read the comment docs.

Copy link

@FryDay FryDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Junhui-AppDirect
Copy link

I'm wondering if there is a timeline about when the react helmet key would be released and could be used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants