Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toasts messages on Fullscreen mode #9325

Closed
wants to merge 1 commit into from
Closed

Fix toasts messages on Fullscreen mode #9325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import debounce from 'debounce'
import PreventUnload from 'vue-prevent-unload'

import { getCurrentUser } from '@nextcloud/auth'
import { setGlobalToastOptions } from '@nextcloud/dialogs'
import { emit, subscribe, unsubscribe } from '@nextcloud/event-bus'
import { generateUrl } from '@nextcloud/router'

Expand Down Expand Up @@ -255,6 +256,8 @@ export default {

this.onResize()

setGlobalToastOptions({ selector: this.$store.getters.getMainContainerSelector().slice(1) })

Comment on lines +259 to +260
Copy link
Contributor

@ShGKme ShGKme Apr 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested yet, but it seems, it should be watch. Otherwise, it sets it once and doesn't update global selector with the getMainContainerSelector update.

window.addEventListener('unload', () => {
console.info('Navigating away, leaving conversation')
if (this.token) {
Expand Down