Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toasts messages on Fullscreen mode #9325

Closed
wants to merge 1 commit into from

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Apr 17, 2023

☑️ Resolves

🚧 Tasks

  • Code review
  • Visual check

🏁 Checklist

@Antreesy Antreesy added this to the 💙 Next Major (27) milestone Apr 17, 2023
@Antreesy Antreesy self-assigned this Apr 17, 2023
@Antreesy Antreesy marked this pull request as draft April 17, 2023 14:19
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly works, but one function is broken and JSDoc is not complete.

Alternative solution: to fix nextcloud-libraries/nextcloud-dialogs#380. Then we would only need to change the default container on fullscreen toggle.

src/utils/showToasts.js Outdated Show resolved Hide resolved
src/utils/showToasts.js Outdated Show resolved Hide resolved
src/utils/showToasts.js Outdated Show resolved Hide resolved
src/utils/showToasts.js Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the fix/noid/add-wrapper-for-toasts branch from 7cdb74e to b599cb4 Compare April 28, 2023 11:15
@Antreesy Antreesy requested a review from ShGKme April 28, 2023 11:17
Comment on lines +259 to +260
setGlobalToastOptions({ selector: this.$store.getters.getMainContainerSelector().slice(1) })

Copy link
Contributor

@ShGKme ShGKme Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested yet, but it seems, it should be watch. Otherwise, it sets it once and doesn't update global selector with the getMainContainerSelector update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants