-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix toasts messages on Fullscreen mode #9325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly works, but one function is broken and JSDoc is not complete.
Alternative solution: to fix nextcloud-libraries/nextcloud-dialogs#380. Then we would only need to change the default container on fullscreen toggle.
src/components/ConversationSettings/ConversationAvatarEditor.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: Maksim Sukharev <[email protected]>
7cdb74e
to
b599cb4
Compare
setGlobalToastOptions({ selector: this.$store.getters.getMainContainerSelector().slice(1) }) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested yet, but it seems, it should be watch. Otherwise, it sets it once and doesn't update global selector with the getMainContainerSelector update.
☑️ Resolves
#content-vue
(which fixes Fullscreen Mode)🚧 Tasks
🏁 Checklist
docs/
has been updated or is not required