Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(invitations): Allow importing CSV email lists #13871

Merged
merged 1 commit into from
Nov 27, 2024
Merged

feat(invitations): Allow importing CSV email lists #13871

merged 1 commit into from
Nov 27, 2024
+893 −2

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 26, 2024 •
edited
Loading

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • Fix psalm
  • Fix OpenAPI
  • Document capability
  • Write integration test

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen marked this pull request as draft November 26, 2024 09:54
@nickvergessen nickvergessen self-assigned this Nov 26, 2024
@nickvergessen nickvergessen added 2. developing enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: meetings 📅 Covering the webinary usecase incl. Lobby feature: conversations 👥 labels Nov 26, 2024
@nickvergessen nickvergessen added this to the 🌠 Next RC (30) milestone Nov 26, 2024
miaulalala
miaulalala reviewed Nov 26, 2024
View reviewed changes
lib/GuestManager.php Outdated Show resolved Hide resolved
miaulalala
miaulalala reviewed Nov 26, 2024
View reviewed changes
lib/GuestManager.php Outdated Show resolved Hide resolved
miaulalala
miaulalala reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nitpicks

Antreesy
Antreesy reviewed Nov 26, 2024
View reviewed changes
lib/GuestManager.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen marked this pull request as ready for review November 26, 2024 13:03
@nickvergessen
Copy link
Member Author

/backport to stable30

@Antreesy Antreesy mentioned this pull request Nov 26, 2024
Merged
11 tasks
Antreesy
Antreesy reviewed Nov 26, 2024
View reviewed changes
lib/GuestManager.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen mentioned this pull request Nov 27, 2024
Merged
4 tasks
miaulalala
miaulalala reviewed Nov 27, 2024
View reviewed changes
lib/GuestManager.php Outdated Show resolved Hide resolved
miaulalala
miaulalala approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! i'd suggest trimming the incoming names / emails

@nickvergessen nickvergessen merged commit 5ca9e8e into main Nov 27, 2024
71 checks passed
@nickvergessen nickvergessen deleted the feat/13451/import-email-list branch November 27, 2024 13:24
@backportbot backportbot bot mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy left review comments

@miaulalala miaulalala miaulalala approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥 feature: meetings 📅 Covering the webinary usecase incl. Lobby
Projects
💬 Talk team
Status: ☑️ Done
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @miaulalala @Antreesy