Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(invitations): Import e-mail participants from CSV 🗒️ #13875

Merged
merged 7 commits into from
Nov 28, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 26, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏡 After 🏡 After
image image
image --
image image

🚧 Tasks

  • Show invited e-mails in the list
  • Another place for 'Import' button?

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not requiredSigned-off-by: Maksim Sukharev [email protected]

@Antreesy Antreesy added 3. to review enhancement feature: frontend 🖌️ "Web UI" client feature: meetings 📅 Covering the webinary usecase incl. Lobby labels Nov 26, 2024
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Nov 26, 2024
@Antreesy Antreesy self-assigned this Nov 26, 2024
@Antreesy Antreesy changed the title fix(LobbyStatus): migrate component to TS feat(invitations): Import e-mail participants from CSV 🗒️ Nov 26, 2024
Base automatically changed from feat/13451/import-email-list to main November 27, 2024 13:24
@DorraJaouad
Copy link
Contributor

DorraJaouad commented Nov 27, 2024

Buttons location:
Why was it related to lobby? IMO it's better if it is in Moderation section under guest access.

User understanding:
There is no clue on how the file should be (format, structure), we discussed these options:

  • Sample file
  • Add documentation and add a link in the dialog for that section

File structure
To change the format to exactly match that of "Download participants"

@nickvergessen nickvergessen force-pushed the feat/13451/import-emails-frontend branch from 3811f7b to 3974bb5 Compare November 28, 2024 05:26
@DorraJaouad
Copy link
Contributor

Show invited e-mails in the list

API is not exposing e-mails upon testing.

Another place for 'Import' button?

Will be kept in Meeting section but under separate subsection

@nickvergessen nickvergessen force-pushed the feat/13451/import-emails-frontend branch from ac7b0aa to af2cbff Compare November 28, 2024 14:39
@nickvergessen nickvergessen marked this pull request as ready for review November 28, 2024 14:39
@nickvergessen
Copy link
Member

/backport to stable30

@DorraJaouad DorraJaouad merged commit dae416f into main Nov 28, 2024
72 of 73 checks passed
@DorraJaouad DorraJaouad deleted the feat/13451/import-emails-frontend branch November 28, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client feature: meetings 📅 Covering the webinary usecase incl. Lobby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants