Acceptance tests for apps management and minor fixes #9810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9810 +/- ##
============================================
+ Coverage 51.92% 51.92% +<.01%
Complexity 25768 25768
============================================
Files 1635 1635
Lines 95426 95427 +1
Branches 1308 1308
============================================
+ Hits 49548 49553 +5
+ Misses 45878 45874 -4
|
skjnldsv
approved these changes
Jun 9, 2018
rullzer
reviewed
Jun 10, 2018
| # being present in the app store with support for the current server version | ||
| # Ideally we would have either a dummy app store endpoint with some test apps | ||
| # or even an app store instance running somewhere to properly test this. | ||
| # This is also a requirement to properly test updates of apps |
There was a problem hiding this comment.
I would vote to write a simple endpoint (just static data that is returned). In the end we test here the apps part of the server. No need to test the appstore at this point.
rullzer
approved these changes
Jun 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some basic acceptance tests for the new apps management (#9769) and fixes some minor bugs from (#9767)