Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue apps issues #9767

Closed
7 tasks done
skjnldsv opened this issue Jun 6, 2018 · 3 comments
Closed
7 tasks done

Vue apps issues #9767

skjnldsv opened this issue Jun 6, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Jun 6, 2018

Following #9565

  • Disabled apps contains all the disabled apps even the ones that are not installed
  • I have an error on load saying: An error occured during the request. Unable to proceed. on a xhr request /ocs/v2.php/cloud/groups?offset=0&limit=-1&search=
  • The script has been shipped as development and not production
  • Clicking the categories does not load anything on my instance (no does create a xhr request)
  • Missing a key in
    <template v-for="bundle in bundles" v-if="useBundleView && bundleApps(bundle.id).length > 0">
  • clicking the remove/disable button open the sidebar
  • removing an app still leave the app displayed on the list
@juliusknorr
Copy link
Member

Fixes are included in #9810, except for:

I have an error on load saying: An error occured during the request. Unable to proceed. on a xhr request /ocs/v2.php/cloud/groups?offset=0&limit=-1&search=

@skjnldsv I cannot reproduce the error, can you check that again?

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 9, 2018

@skjnldsv I cannot reproduce the error, can you check that again?

Apparently we're loading the getGroups function beforeMount
this.$store.dispatch('getGroups', {offset: 0, limit: -1});

The limit is somehow breaking my instance:
Error: /ocs/v2.php/cloud/groups?offset=0&limit=-1&search=
Ok: /ocs/v2.php/cloud/groups?offset=0&limit=1&search=

@MorrisJobke
Copy link
Member

Remaining items were fixed in #10103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants