Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(installer): Label field as username instead of login #49500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

fix(installer): Label field as username instead of login #49500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/templates/installation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<fieldset id="adminaccount">
<legend><?php print_unescaped($l->t('Create an <strong>admin account</strong>')); ?></legend>
<p>
<label for="adminlogin"><?php p($l->t('Login')); ?></label>
<label for="adminlogin"><?php p($l->t('Username')); ?></label>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Account name" instead (to match LoginForm)?

server/core/src/components/login/LoginForm.vue

Lines 239 to 244 in e17f011

loginText() {
if (this.emailEnabled) {
return t('core', 'Account name or email')
}
return t('core', 'Account name')
},

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up to you. I'd prefer "Username" as it's more intuitive.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Account name" is what everything has been switched to as of v30 so let's go with that for consistency.

<input type="text" name="adminlogin" id="adminlogin"
value="<?php p($_['adminlogin']); ?>"
autocomplete="off" autocapitalize="none" spellcheck="false" autofocus required>
Expand Down
Loading