fix(installer): Label field as username instead of login #49500
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
solracsf
approved these changes
Nov 27, 2024
Signed-off-by: HB9HIL <[email protected]>
HB9HIL
force-pushed
the
installer_login
branch
from
7acfa49
to
2b270af
Compare
This comment was marked as resolved.
This comment was marked as resolved.
solracsf
changed the title
| @@ -40,7 +40,7 @@ | |||
| <fieldset id="adminaccount"> | |||
| <legend><?php print_unescaped($l->t('Create an <strong>admin account</strong>')); ?></legend> | |||
| <p> | |||
| <label for="adminlogin"><?php p($l->t('Login')); ?></label> | |||
| <label for="adminlogin"><?php p($l->t('Username')); ?></label> | |||
There was a problem hiding this comment.
Maybe "Account name" instead (to match LoginForm)?
server/core/src/components/login/LoginForm.vue
Lines 239 to 244 in e17f011
There was a problem hiding this comment.
It's up to you. I'd prefer "Username" as it's more intuitive.
There was a problem hiding this comment.
"Account name" is what everything has been switched to as of v30 so let's go with that for consistency.
|
Good catch, @HB9HIL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The intended username field in the installer is labeled "Login" which translates in many languages in a different meaning. It's better to label it Username.
Before:
After:
TODO
Nothing
Checklist