Enh/share expiration notification #17727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
added
enhancement
2. developing
apps/files_sharing/lib/BackgroundJob/ExiprationNotificationJob.php
Outdated
Show resolved
Hide resolved
|
As discussed lets move this to a command that can be run |
rullzer
force-pushed
the
enh/share_expiration_notification
branch
from
027e695 to
d773cc2
Compare
|
Moved it to a command you can now run once a day or so from cron. |
rullzer
force-pushed
the
enh/share_expiration_notification
branch
from
d773cc2 to
377e144
Compare
Why not make like #3044, one mode with background jobs and one with command? |
|
@tcitworld because right now I don't want to have this by default. Only systems that want to have this will have to run the command. Also since we can't gurantee whena background job is run this creates some issues right now ;) |
Introduces a new command that will create notifications for users if they have shares that will expire the next day. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
enh/share_expiration_notification
branch
from
377e144 to
1ac57e7
Compare
rullzer
requested review from
skjnldsv,
juliusknorr,
ChristophWurst,
danxuliu and
nickvergessen
rullzer
added
3. to review
|
Rebased, review tine |
skjnldsv
reviewed
Nov 1, 2019
| public function execute(InputInterface $input, OutputInterface $output) { | ||
| //Current time | ||
| $minTime = $this->time->getDateTime(); | ||
| $minTime->add(new \DateInterval('P1D')); |
There was a problem hiding this comment.
So we always use the server time to expire, right?
We don't store any utc shift?
ChristophWurst
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Todo: