-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance backgroundjob timings #17726
Conversation
Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
@ChristophWurst @nickvergessen @blizzz @juliushaertl @skjnldsv feedback is welcome ;) |
My main concern with stuff like this is, we can not know whethere an instance has such working times, and when they are. 🤔 |
Well sure. But that is the same with jobs right now. My concern is that with some jobs that run daily we have to make sure they run early that day. Otherwise the notification might not make sense anymore |
Which jobs are those? |
|
Yes, but the argument remains that we don't know the working hours of every instance. Instances are also used for different time zones and then "night", "day" and "early that day" are ambiguous time frames. |
@ChristophWurst not really. If your machine operates in timezone A. then allyour share expiration dates are in that timezone. So if you want to clean them up In any case. @nickvergessen had a better idea so lets close this for now. |
This adds the AtJob backgroundjob. A background job that will run once a day after, but as close to the specified time as possible.
Example usages:
There is also teh dailyJob which is just a prefilled instance to run at midnight.
TODO;