Fix remaining apps management issues #10103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
changed the title
skjnldsv
reviewed
Jul 4, 2018
| @@ -60,7 +60,8 @@ | |||
| <multiselect v-if="isLimitedToGroups(app)" :options="groups" :value="appGroups" @select="addGroupLimitation" @remove="removeGroupLimitation" :options-limit="5" | |||
| :placeholder="t('settings', 'Limit app usage to groups')" | |||
| label="name" track-by="id" class="multiselect-vue" | |||
| :multiple="true" :close-on-select="false"> | |||
| :multiple="true" :close-on-select="false" | |||
| @search-change="asyncFindGroup"> | |||
There was a problem hiding this comment.
Nice! Did not know we could do that!
skjnldsv
reviewed
Jul 4, 2018
| <input v-if="app.canUnInstall" class="uninstall" type="button" :value="t('settings', 'Remove')" v-on:click="remove(app.id)" :disabled="installing || loading(app.id)" /> | ||
| <input v-if="app.active" class="enable" type="button" :value="t('settings','Disable')" v-on:click="disable(app.id)" :disabled="installing || loading(app.id)" /> | ||
| <input v-if="!app.active" class="enable" type="button" :value="enableButtonText" v-on:click="enable(app.id)" v-tooltip.auto="enableButtonTooltip" :disabled="!app.canInstall || installing || loading(app.id)" /> | ||
| <input v-if="app.update" class="update" type="button" :value="t('settings', 'Update to {update}', {update:app.update})" v-on:click.stop="update(app.id)" :disabled="installing || loading(app.id)" /> |
There was a problem hiding this comment.
So nice to have such easy fix in vue! :')
skjnldsv
reviewed
Jul 4, 2018
| @@ -54,6 +54,9 @@ | |||
| } | |||
| }, | |||
| methods: { | |||
| asyncFindGroup(query) { | |||
| return this.$store.dispatch('getGroups', {search: query, limit: 5, offset: 0}); | |||
There was a problem hiding this comment.
So we only show the 5 first matches?
I'm fine with it!
There was a problem hiding this comment.
Yes, it will fetch more results while typing.
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/9767/apps-management-issues
branch
from
ed02fb8 to
2e3d78a
Compare
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/9767/apps-management-issues
branch
from
2e3d78a to
1e1f164
Compare
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the rest of #9767