Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media View in SwiftUI #2606

Closed
wants to merge 127 commits into from
Closed

Media View in SwiftUI #2606

wants to merge 127 commits into from

Conversation

@mpivchev mpivchev linked an issue Sep 26, 2023 that may be closed by this pull request
@mpivchev mpivchev changed the title Media View in SwiftUI [1] Media View in SwiftUI Oct 2, 2023
@mpivchev mpivchev changed the title [1] Media View in SwiftUI Media View in SwiftUI Oct 2, 2023
@marinofaggiana
Copy link
Member

In landscape mode isn't full screen :

Screenshot 2023-10-02 alle 17 16 18

@marinofaggiana
Copy link
Member

When select a image the navigation bar isn't normalized :
note. navigationController?.setFileAppreance()

Screenshot 2023-10-02 alle 17 20 43

@marinofaggiana
Copy link
Member

When scroll the images down quickly the queue of preview is not deleted, the result is that you have to wait a very long time before all previous images are loaded (see old code).

@mpivchev
Copy link
Collaborator Author

mpivchev commented Oct 2, 2023

@marinofaggiana What do you think about the performance when zoomed out fully?

IMO the performance is not good, and we can open a separate issue to try and fix it as much as possible by:

  • Looking at the profiler and checking what causes low framerate and fixing it

  • Replacing normal Image View with NukeUI or Kingfisher for better performance. I already tried briefly using NukeUI, but it needs additional work

    • Caching should be done by NukeUI instead of Realm
    • Some SwiftUI code needs to be rewritten

@mpivchev
Copy link
Collaborator Author

mpivchev commented Oct 2, 2023

When scroll the images down quickly the queue of preview is not deleted, the result is that you have to wait a very long time before all previous images are loaded (see old code).

Yeah maybe doing this would help with performance a bit

Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
@mpivchev mpivchev force-pushed the 2399-aspect-ratio-in-media-view branch from 028be12 to ce38d89 Compare January 11, 2024 15:19
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Signed-off-by: Milen Pivchev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants