New Media View - Loading indicators

[mpivchev]

Related to: #2606

Old Media View had loading indicators for various actions, but the new one does not. The reason is the old indicators were part of a UIKit library, but we need to find a different solution for SwiftUI

There is a SwiftUI version of this lib, but after briefly trying it it didn't seem to work super well.

[marinofaggiana]

it is necessary ?

[mpivchev]

Yes, otherwise there is no feedback on what's happening.

[mpivchev]

@nextcloud/designers @marinofaggiana Regarding loading new metadata from the server, we need to have a loading indicator in a place that is always visible, like the toolbar. I think putting it here is a good solution:

[marinofaggiana]

Some consideration about new media (the indicator in the image is perfect for view the activity):

• when you arrive in Media tab you can search new media image (searchNewMedia()) this is sufficient to detect any undetected images when starting the app.
• to detect any new ones, simply return to the TOP to resend the query to the server, so pull to refresh is useless, pull to refresh is useful but in other contexts.
• when in the bottom you use the func searchOldMedia()
• the timer is indispensable so as not to send too many unnecessary queries to the server, especially when moving between images, this allows us to send the request only when it is wanted especially between intermediate dates , remember that images can be deleted or added via the web or other devices with dates before the current one, the system must detect them.
• about delete or move, the best would be to make images marked to delete or move immediately removed (flag hide?) if everything works well you can also delete them otherwise an error will make them visible again; this would allow us not to use the ugly hud, via UIKit with the indexPath system this is not easy because crashes might happen but perhaps in swiftUI which has a completely different logic it becomes controllable.

---

in the searchOldMedia() and searchNewMedia() is used the :

let updateMetadatas = NCManageDatabase.shared.updateMetadatas(metadatas, metadatasResult: metadatasResult, addCompareLivePhoto: false) this allows us to know whether there has been any variation from the result updateMetadatas, this can allow us to manage even just in memory without re-executing the whole query from the DB.

Via the server, work is being done to make livephoto native, which will allow us to streamline the database work a lot in the future without having to put the results into an array but only handle the pointers.