Chart update adding Service Annotations ie for LB Use, Issue #185 #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ud#185' Signed-off-by: Stephan Kristyn <[email protected]>
wethinkagile
force-pushed
the
add-helm-service-annotations
branch
from
b5d9962 to
b307335
Compare
jessebot
reviewed
May 5, 2024
jessebot
reviewed
May 5, 2024
jessebot
requested changes
May 5, 2024
Signed-off-by: Jesse Hitch <[email protected]>
jessebot
changed the title
Signed-off-by: Jesse Hitch <[email protected]>
Signed-off-by: jessebot <[email protected]>
jessebot
force-pushed
the
add-helm-service-annotations
branch
from
f501e92 to
e3404a9
Compare
|
After much turmoil related almost entirely to whitespace (of my own making 🤦), I think this is finally ready after the tests pass :) |
jessebot
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Adding Service Type Annotations
Benefits
Adding Service Type Annotations
Possible drawbacks
None
Applicable issues
Additional information
Updated Readme
Checklist
Chart.yamlaccording to semver.