Skip to content

Commit

Permalink
Chart update adding Service Annotations ie for LB Use, Issue #185 (#565)
Browse files Browse the repository at this point in the history
* Chart update adding Service Annotations ie for LB Use, Issue #185

Signed-off-by: Stephan Kristyn <[email protected]>

* Update charts/nextcloud/templates/service.yaml - use with instead of if/with for annotations

Signed-off-by: Jesse Hitch <[email protected]>

* Update README.md - fix parameter table spacing

Signed-off-by: jessebot <[email protected]>

---------

Signed-off-by: Stephan Kristyn <[email protected]>
Signed-off-by: jessebot <[email protected]>
Co-authored-by: Stephan Kristyn <[email protected]>
Co-authored-by: jessebot <[email protected]>
  • Loading branch information
3 people authored Jul 22, 2024
1 parent 2192ce8 commit ddf49e9
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion charts/nextcloud/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: nextcloud
version: 5.2.1
version: 5.2.2
appVersion: 29.0.3
description: A file sharing server that puts the control and security of your own data back into your hands.
keywords:
Expand Down
1 change: 1 addition & 0 deletions charts/nextcloud/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ The following table lists the configurable parameters of the nextcloud chart and
| `cronjob.securityContext` | Optional security context for cron jobs sidecar | `nil` |
| `service.type` | Kubernetes Service type | `ClusterIP` |
| `service.loadBalancerIP` | LoadBalancerIp for service type LoadBalancer | `""` |
| `service.annotations` | Annotations for service type | `{}` |
| `service.nodePort` | NodePort for service type NodePort | `nil` |
| `service.ipFamilies` | Set ipFamilies as in k8s service objects | `nil` |
| `service.ipFamyPolicy` | define IP protocol bindings as in k8s service objects | `nil` |
Expand Down
8 changes: 6 additions & 2 deletions charts/nextcloud/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ apiVersion: v1
kind: Service
metadata:
name: {{ template "nextcloud.fullname" . }}
{{- with .Values.service.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
labels:
app.kubernetes.io/name: {{ include "nextcloud.name" . }}
helm.sh/chart: {{ include "nextcloud.chart" . }}
Expand All @@ -17,7 +21,7 @@ spec:
{{- end }}
{{- end }}
{{- with .Values.service.ipFamilies }}
ipFamilies:
ipFamilies:
{{- toYaml . | nindent 4 }}
{{- end }}
{{- with .Values.service.ipFamilyPolicy }}
Expand All @@ -34,4 +38,4 @@ spec:
selector:
app.kubernetes.io/name: {{ include "nextcloud.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/component: app
app.kubernetes.io/component: app
3 changes: 3 additions & 0 deletions charts/nextcloud/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,9 @@ service:
port: 8080
loadBalancerIP: ""
nodePort: nil
annotations: {}
## Insert your annotations such as below
# test/test: pumuckel

## Enable persistence using Persistent Volume Claims
## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/
Expand Down

0 comments on commit ddf49e9

Please sign in to comment.