feat: keep PVCs when uninstalling helm chart #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #473 |
|
Ok let's go with this PR because the other PR is stale... |
provokateurin
requested changes
Apr 11, 2024
Leptopoda
force-pushed
the
feat/keep_pvcs_on_uninstall
branch
from
91800de to
54f10b8
Compare
provokateurin
requested changes
Apr 11, 2024
Leptopoda
force-pushed
the
feat/keep_pvcs_on_uninstall
branch
from
54f10b8 to
f168fad
Compare
Signed-off-by: Nikolas Rimikis <[email protected]>
Leptopoda
force-pushed
the
feat/keep_pvcs_on_uninstall
branch
from
f168fad to
d5e757c
Compare
provokateurin
approved these changes
Apr 11, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Keep nextcloud PVCs when uninstalling the helm chart
Benefits
Most helm charts keep PVCs on uninstall. The current nextcloud approach is unexpected and thus may lead to data loss.
Learned that the hard way 😅
Possible drawbacks
None that I'm aware of.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.