Explicitly sets helm resource policy to keep #473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Veymax <[email protected]>
Signed-off-by: JesseBot <[email protected]>
|
Do we need anything else to merge this ? |
provokateurin
approved these changes
Jan 20, 2024
3 tasks
|
Done in #555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Sets default helm resource policy to 'keep', preventing helm from deleting
nextcloudandnextcloud-datapvcs when uninstalled, in contrast with best practice.Benefits
Decreases the chance of unintentional data loss
Possible drawbacks
Forces users to be intentional about deleting their PVCs. In a certain light, this is a benefit.
Applicable issues
Additional information
This should be all
Checklist
Chart.yamlaccording to semver.