Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only present proxy password delete error if it is not a "does not exist" error #7468

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

claucambra
Copy link
Collaborator

Prevent error on deletion when the proxy password does not exist

@claucambra claucambra added this to the 3.14.5 milestone Nov 6, 2024
@claucambra claucambra self-assigned this Nov 6, 2024
@claucambra claucambra force-pushed the bugfix/delete-proxypass-whenempty branch from cd98ca2 to 6cd1c5b Compare November 6, 2024 17:17
@claucambra claucambra changed the title Only delete proxy password when it is, in fact, previously present in the settings Only present proxy password delete error if it is not a "does not exist" error Nov 6, 2024
…st" error

Prevent error on deletion when the proxy password does not exist

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra claucambra force-pushed the bugfix/delete-proxypass-whenempty branch from 6cd1c5b to fa33dd6 Compare November 8, 2024 04:41
@claucambra
Copy link
Collaborator Author

/backport to stable-3.14

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7468-fa33dd61cf22364ef3eeea0dc910f557b7a27525-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit c0ffd38 into master Nov 8, 2024
11 of 14 checks passed
@claucambra claucambra deleted the bugfix/delete-proxypass-whenempty branch November 8, 2024 04:55
Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
12 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Rello Rello modified the milestones: 3.14.5, 3.15.0 Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants