Only delete proxy password when it is, in fact, previously present in…

… the settings Prevent error on deletion when the proxy password does not exist Signed-off-by: Claudio Cambra <[email protected]>
nextcloud · Nov 6, 2024 · cd98ca2 · cd98ca2
1 parent a255c1f
commit cd98ca2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/gui/accountmanager.cpp b/src/gui/accountmanager.cpp
@@ -357,7 +357,7 @@ void AccountManager::saveAccountHelper(Account *acc, QSettings &settings, bool s
     settings.setValue(networkDownloadLimitC, acc->downloadLimit());
 
     const auto proxyPasswordKey = QString(acc->userIdAtHostWithPort() + networkProxyPasswordKeychainKeySuffixC);
-    if (const auto proxyPassword = acc->proxyPassword(); proxyPassword.isEmpty()) {
+    if (const auto proxyPassword = acc->proxyPassword(); proxyPassword.isEmpty() && settings.value(proxyPasswordKey).isValid()) {
         const auto job = new QKeychain::DeletePasswordJob(Theme::instance()->appName(), this);
         job->setKey(proxyPasswordKey);
         connect(job, &QKeychain::Job::finished, this, [](const QKeychain::Job *const incomingJob) {