Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect the terms of service app is requiring the user to sign them #7385

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

mgallien
Copy link
Collaborator

will query the sign state for the terms of service and automatically pause or resume sync

@mgallien
Copy link
Collaborator Author

/backport to stable-3.13

@mgallien
Copy link
Collaborator Author

/backport to stable-3.12

@mgallien
Copy link
Collaborator Author

/backport to stable-3.14

src/gui/folder.cpp Outdated Show resolved Hide resolved
src/gui/owncloudgui.cpp Outdated Show resolved Hide resolved
Copy link
Member

@camilasan camilasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just very minor comments.

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Camila's suggestions, otherwise LGTM

@mgallien mgallien force-pushed the bugfix/dealWithToSApp branch from 7537976 to f260ef3 Compare October 22, 2024 12:32
@mgallien mgallien requested a review from camilasan October 22, 2024 12:32
will query the sign state for the terms of service and automatically
pause or resume sync

Signed-off-by: Matthieu Gallien <[email protected]>
will trigger a check of the server connectivity in case of content
access denied reporting when listing folders during discovery

should allow discovering early that terms of service need to be signed

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the bugfix/dealWithToSApp branch from 99927f1 to 968289c Compare October 22, 2024 13:03
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7385-968289cbf0c287a4f58d751ff098e7b658e644da-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots
6.4% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)
D Maintainability Rating on New Code (required ≥ A)
1 New Bugs (required ≤ 0)
74 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants