Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.13] detect the terms of service app is requiring the user to sign them #7388

Closed
wants to merge 2 commits into from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 22, 2024

Backport of #7385

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

will query the sign state for the terms of service and automatically
pause or resume sync

Signed-off-by: Matthieu Gallien <[email protected]>
@backportbot backportbot bot requested review from camilasan and mgallien October 22, 2024 13:40
@backportbot backportbot bot added this to the 3.13.5 milestone Oct 22, 2024
will trigger a check of the server connectivity in case of content

access denied reporting when listing folders during discovery

should allow discovering early that terms of service need to be signed

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the backport/7385/stable-3.13 branch from ae98d55 to c2871c2 Compare October 22, 2024 15:58
@mgallien mgallien marked this pull request as ready for review October 22, 2024 15:58
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7388-c2871c28bb8a69e6d04f13dc9c444a9e636e227d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien closed this Oct 22, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.4% Coverage on New Code (required ≥ 80%)
7 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants