prevent event loop reentrance when handling ENCRYPT socket requests #6958
Conversation
|
/backport to stable-3.13 |
|
/backport to stable-3.12 |
when receiving a shell integration socket command for ENCRYPT, a generic interface and generic code paths was used the assumption was that the listener socket would need (and remain) valid while hanlding teh request some code paths need to display error messages to the user via a QMessageBox the issue is that this will execute a Qt event loop that will handle the socket disconnection while the socket variable from the caller seems it will stay valid and alive prevent that by not using a blocking method invocation such that life time mishandling about the socket listener is not possible Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/preventCrashOnEncryptShellIntegrationRequests
branch
from
9d665ca to
f2cfd2c
Compare
|
AppImage file: nextcloud-PR-6958-f2cfd2cc80fd5120a2789914630ee7e69f98335c-x86_64.AppImage |
|
mgallien
deleted the
bugfix/preventCrashOnEncryptShellIntegrationRequests
branch
|
The backport to # Switch to the target branch and update it
git checkout stable-3.12
git pull origin stable-3.12
# Create the new backport branch
git checkout -b backport/6958/stable-3.12
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f2cfd2cc
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6958/stable-3.12Error: Failed to clone repository: Failed to checkout branches: error: Your local changes to the following files would be overwritten by checkout: Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
when receiving a shell integration socket command for ENCRYPT, a generic interface and generic code paths was used
the assumption was that the listener socket would need (and remain) valid while hanlding teh request
some code paths need to display error messages to the user via a QMessageBox
the issue is that this will execute a Qt event loop that will handle the socket disconnection while the socket variable from the caller seems it will stay valid and alive
prevent that by not using a blocking method invocation such that life time mishandling about the socket listener is not possible