Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.13] prevent event loop reentrance when handling ENCRYPT socket requests #6979

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 7, 2024

Backport of PR #6958

@backportbot backportbot bot requested review from claucambra and mgallien August 7, 2024 10:17
@backportbot backportbot bot added this to the 3.13.3 milestone Aug 7, 2024
when receiving a shell integration socket command for ENCRYPT, a generic
interface and generic code paths was used

the assumption was that the listener socket would need (and remain)
valid while hanlding teh request

some code paths need to display error messages to the user via a
QMessageBox

the issue is that this will execute a Qt event loop that will handle the
socket disconnection while the socket variable from the caller seems it
will stay valid and alive

prevent that by not using a blocking method invocation such that life
time mishandling about the socket listener is not possible

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the backport/6958/stable-3.13 branch from dd6917c to ad504ea Compare August 7, 2024 10:56
@mgallien mgallien enabled auto-merge August 7, 2024 10:56
Copy link

sonarqubecloud bot commented Aug 7, 2024

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6979-ad504eaf9ef3af55ff8605d02f97de440a1d1451-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 66c355a into stable-3.13 Aug 8, 2024
11 of 13 checks passed
@mgallien mgallien deleted the backport/6958/stable-3.13 branch August 8, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants