Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Edit Locally support to macOS virtual files module #6803

Merged
merged 30 commits into from
Jul 22, 2024
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
5a3dccd
Add starter EditLocallyVerificationJob
claucambra May 23, 2024
d8f5996
Send and respond to SimpleApiJob to verify edit locally request with …
claucambra May 23, 2024
1422df7
Ensure verification job gets deleted after finish
claucambra May 23, 2024
a5713fc
Use verification job within edit locally job
claucambra May 23, 2024
e38368d
Move token and relpath validity checks to edit locally verification job
claucambra May 23, 2024
a5c7bfe
Ensure we emit error during edit locally job setup issues
claucambra May 27, 2024
7761182
Directly use accountstate in editlocallyjob
claucambra May 27, 2024
1659b21
Add a EditLocallyVerificationJobPtr type
claucambra May 27, 2024
83beaf8
Move verification job handling and scheduling out of editlocallyjob, …
claucambra May 27, 2024
35f988d
Move show error display features from editlocallyjob to editlocallyma…
claucambra May 27, 2024
00cd258
Remove token related tasks from editlocallyjob
claucambra May 27, 2024
263563d
Display token verification failure through GUI in edit locally manager
claucambra May 27, 2024
1080389
Show edit locally loading dialog with filename immediately in editloc…
claucambra May 27, 2024
5df96b8
Do not automatically delete edit locally token verification job upon …
claucambra May 27, 2024
834e096
Add starter FileProviderEditLocally class
claucambra May 28, 2024
7ee296a
Add FileProviderEditLocallyPtr type
claucambra May 28, 2024
9642a03
Add completion signals to fileprovidereditlocallyjob
claucambra May 28, 2024
5ce3cdc
Try to use FileProviderEditLocallyJob before attempting standard Edit…
claucambra May 28, 2024
eb5fa21
Add showError to FileProviderEditLocally
claucambra May 28, 2024
98a0d81
Begin setting up dialog for file provider edit locally job
claucambra May 28, 2024
231d30e
Fetch ocId for a given relative path
claucambra May 28, 2024
26c08e4
Expose domain manager in Mac::FileProvider
claucambra May 28, 2024
a5a9a02
Allow retrieval of domain associated with account in FileProviderDoma…
claucambra May 28, 2024
47c09f9
Anticipate null reply in idGetError of FileProviderEditLocallyJob
claucambra May 28, 2024
7adce87
Remove redundant includes in editlocallymanager
claucambra May 28, 2024
1538280
Implement opening of a file with a given ocId in File Provider files
claucambra May 28, 2024
e345cd4
Connect receipt of a file's ocId with file opening procedure in FileP…
claucambra May 28, 2024
52e29fe
Improve logging in editlocallymanager
claucambra May 28, 2024
8147e83
Start the FileProviderEditLocallyJob in editlocallymanager
claucambra May 28, 2024
27bc838
Fix crash upon removing edit locally file provider jobs in edit local…
claucambra May 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add FileProviderEditLocallyPtr type
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
  • Loading branch information
claucambra committed Jul 22, 2024
commit 7ee296acdb68c514f1e84a22f20da3a24d2a90eb
3 changes: 3 additions & 0 deletions src/gui/macOS/fileprovidereditlocallyjob.h
Original file line number Diff line number Diff line change
@@ -21,6 +21,9 @@

namespace OCC::Mac {

class FileProviderEditLocallyJob;
using FileProviderEditLocallyJobPtr = QSharedPointer<FileProviderEditLocallyJob>;

class FileProviderEditLocallyJob : public QObject
{
Q_OBJECT