Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Edit Locally support to macOS virtual files module #6803

Merged
merged 30 commits into from
Jul 22, 2024
Merged

Add Edit Locally support to macOS virtual files module #6803

merged 30 commits into from
Jul 22, 2024

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Jun 9, 2024 •
edited
Loading

Closes #6739
Closes #6195

@claucambra claucambra self-assigned this Jun 9, 2024
@claucambra claucambra force-pushed the feature/edit-locally-macos-vfs branch from a262a61 to 5088713 Compare June 9, 2024 09:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
23 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@claucambra claucambra added this to the 3.14.0 milestone Jun 20, 2024
camilasan
camilasan approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@camilasan camilasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just squash some commits.

claucambra added 20 commits July 22, 2024 19:51
@claucambra
Add starter EditLocallyVerificationJob
5a3dccd 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Send and respond to SimpleApiJob to verify edit locally request with …
d8f5996 
…server in validation job

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Ensure verification job gets deleted after finish
1422df7 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Use verification job within edit locally job
a5713fc 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Move token and relpath validity checks to edit locally verification job
e38368d 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Ensure we emit error during edit locally job setup issues
a5c7bfe 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Directly use accountstate in editlocallyjob
7761182 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add a EditLocallyVerificationJobPtr type
1659b21 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Move verification job handling and scheduling out of editlocallyjob, …
83beaf8 
…into editlocallymanager

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Move show error display features from editlocallyjob to editlocallyma…
35f988d 
…nager

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Remove token related tasks from editlocallyjob
00cd258 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Display token verification failure through GUI in edit locally manager
263563d 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Show edit locally loading dialog with filename immediately in editloc…
1080389 
…allyjob constructor

By the time we launch this job we ahve already finished verifying the
token after recent changes

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Do not automatically delete edit locally token verification job upon …
5df96b8 
…completion, rely on manager's smart pointers

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add starter FileProviderEditLocally class
834e096 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add FileProviderEditLocallyPtr type
7ee296a 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add completion signals to fileprovidereditlocallyjob
9642a03 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Try to use FileProviderEditLocallyJob before attempting standard Edit…
5ce3cdc 
…LocallyJob in EditLocallyManager

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add showError to FileProviderEditLocally
eb5fa21 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Begin setting up dialog for file provider edit locally job
98a0d81 
Signed-off-by: Claudio Cambra <[email protected]>
claucambra added 10 commits July 22, 2024 19:51
@claucambra
Fetch ocId for a given relative path
231d30e 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Expose domain manager in Mac::FileProvider
26c08e4 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Allow retrieval of domain associated with account in FileProviderDoma…
a5a9a02 
…inManager

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Anticipate null reply in idGetError of FileProviderEditLocallyJob
47c09f9 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Remove redundant includes in editlocallymanager
7adce87 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Implement opening of a file with a given ocId in File Provider files
1538280 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Connect receipt of a file's ocId with file opening procedure in FileP…
e345cd4 
…roviderEditLocallyJob

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Improve logging in editlocallymanager
52e29fe 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Start the FileProviderEditLocallyJob in editlocallymanager
8147e83 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Fix crash upon removing edit locally file provider jobs in edit local…
27bc838 
…ly manager

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra claucambra force-pushed the feature/edit-locally-macos-vfs branch from fe23819 to 27bc838 Compare July 22, 2024 11:51
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6803-27bc838c9c0c5e78d43ed4aee7a55e994674cd63-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
22 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@claucambra claucambra merged commit 764ae8e into master Jul 22, 2024
14 of 16 checks passed
@claucambra claucambra deleted the feature/edit-locally-macos-vfs branch July 22, 2024 13:00
@t3nk3y t3nk3y mentioned this pull request Sep 23, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilasan camilasan camilasan approved these changes

@mgallien mgallien Awaiting requested review from mgallien

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

@claucambra claucambra

Labels
feature: 💽 virtual filesystem os: 🍎 macOS
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.

Add "edit locally" to File Provider Module Implement edit locally in File provider-based VFS
3 participants
@claucambra @nextcloud-desktop-bot @camilasan