-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On folder move execute only one UPDATE query for all nested items. #6211
base: master
Are you sure you want to change the base?
Conversation
9b38399
to
982df39
Compare
42276df
to
08e1958
Compare
SonarCloud Quality Gate failed. 0 Bugs 83.5% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
ccc72ba
to
cb9e5ac
Compare
147c170
to
35e5446
Compare
35e5446
to
18008eb
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
18008eb
to
122ae9c
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Signed-off-by: alex-z <[email protected]>
Signed-off-by: alex-z <[email protected]>
…target such that it is the same move. Signed-off-by: alex-z <[email protected]>
Signed-off-by: alex-z <[email protected]>
Signed-off-by: alex-z <[email protected]>
Signed-off-by: alex-z <[email protected]>
Signed-off-by: alex-z <[email protected]>
Signed-off-by: alex-z <[email protected]>
Signed-off-by: alex-z <[email protected]>
Signed-off-by: alex-z <[email protected]>
Signed-off-by: alex-z <[email protected]>
Signed-off-by: alex-z <[email protected]>
Signed-off-by: alex-z <[email protected]>
Signed-off-by: alex-z <[email protected]>
Signed-off-by: alex-z <[email protected]>
122ae9c
to
2a7adfe
Compare
AppImage file: nextcloud-PR-6211-2a7adfe766f6258e420c2b51dee79447684c40c2-x86_64.AppImage |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
So, the idea here is to not execute
INSERT
query for every nested item of moved folder (there can be thousands of items and this is very very slow and also brings an issue of user moving/renaming the same folder multiple times, causing local database records to become messed up and virtual files being removed on a later sync). Instead, theUPDATE
query is executed, which is very fast. Tested on 1000 files so far so good.Let's keep it draft for now until I have time to properly finalize it.
Should fix #4636 or at least make it much less likely to happen.