Skip to content

Commit

Permalink
Added some todos.
Browse files Browse the repository at this point in the history
Signed-off-by: alex-z <[email protected]>
  • Loading branch information
allexzander committed Jan 10, 2024
1 parent 3f2c953 commit cb9e5ac
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions src/libsync/owncloudpropagator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,8 @@ void OwncloudPropagator::start(SyncFileItemVector &&items)
// when a folder is moved on the local device we only need to perform one MOVE on the server and then just update database, so we only keep unique moves (topmost moved folder items)
cleanupLocallyMovedFoldersFromNestedItems(items);

//TODO: After cleanup, in case items size changes, we need to update the progress info (maybe in: void SyncEngine::slotDiscoveryFinished or move this code to slotDiscoveryFinished)

qCInfo(lcPropagator) << "END ITEMS CLEANUP";
for (const auto &item : items) {
qCInfo(lcPropagator) << "item->_originalFile:"
Expand Down
2 changes: 1 addition & 1 deletion src/libsync/propagateremotemove.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ void PropagateRemoteMove::finalize()
// the following slow code is only useful for VFS with suffix which is used for TestSyncVirtualFiles::testPinStateLocals test case
// TODO: Get rid of the TestSyncVirtualFiles::testPinStateLocals or change it, native Virtual Files (e.g. CfAPI do not need this code as pinstate is moved with corresponding placeholder)
if (!propagator()->_journal->getFilesBelowPath(_item->_renameTarget.toUtf8(), [&](const SyncJournalFileRecord &rec) {
// not sure if this is needed, inode seems to never change for move/rename
// TODO: not sure if this is needed, inode seems to never change for move/rename
auto newItem = SyncFileItem::fromSyncJournalFileRecord(rec);
newItem->_originalFile = QString(newItem->_file).replace(_item->_renameTarget, origin);
newItem->_renameTarget = newItem->_file;
Expand Down

0 comments on commit cb9e5ac

Please sign in to comment.