-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead OAuth code #6005
Remove dead OAuth code #6005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claucambra can you fix the compilation issues ?
b937993
to
a780634
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
Now fixed :) |
a780634
to
203369a
Compare
No clang-tidy warnings found so I assume my comments were addressed
203369a
to
f4cac50
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6005 +/- ##
==========================================
+ Coverage 60.23% 60.34% +0.10%
==========================================
Files 145 145
Lines 18868 18793 -75
==========================================
- Hits 11366 11340 -26
+ Misses 7502 7453 -49
|
f4cac50
to
e097ba9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compilation still fails:
continuous-integration/drone/pr — Build is failing
e097ba9
to
ceee1da
Compare
@claucambra please fix the conflict ? |
ceee1da
to
3be0a8e
Compare
now fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
3be0a8e
to
e8b4645
Compare
Signed-off-by: Claudio Cambra <[email protected]>
e8b4645
to
6cf04d6
Compare
AppImage file: nextcloud-PR-6005-6cf04d660b8ba7cf59c227826a0ecf718a0b0c16-x86_64.AppImage |
SonarCloud Quality Gate failed. 0 Bugs 14.3% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
/backport to stable-3.10 |
The backport to stable-3.10 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable-3.10
git pull origin stable-3.10
# Create the new backport branch
git checkout -b fix/foo-stable-3.10
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-3.10 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Fixes #3692