Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead OAuth code #6005

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Aug 29, 2023

Fixes #3692

@claucambra claucambra self-assigned this Aug 29, 2023
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claucambra can you fix the compilation issues ?

@claucambra claucambra force-pushed the work/remove-unused-oauth-theme-values branch from b937993 to a780634 Compare August 29, 2023 09:16
@claucambra claucambra changed the title Remove unused OAuth hardcoded values Remove dead OAuth code Aug 29, 2023
@claucambra claucambra linked an issue Aug 29, 2023 that may be closed by this pull request
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

src/gui/creds/httpcredentialsgui.h Outdated Show resolved Hide resolved
@claucambra
Copy link
Collaborator Author

@claucambra can you fix the compilation issues ?

Now fixed :)

@claucambra claucambra requested a review from mgallien August 31, 2023 02:47
@claucambra claucambra force-pushed the work/remove-unused-oauth-theme-values branch from a780634 to 203369a Compare August 31, 2023 02:52
@github-actions github-actions bot dismissed their stale review August 31, 2023 03:00

No clang-tidy warnings found so I assume my comments were addressed

@mgallien mgallien force-pushed the work/remove-unused-oauth-theme-values branch from 203369a to f4cac50 Compare September 7, 2023 11:14
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #6005 (6cf04d6) into master (9e74f5c) will increase coverage by 0.10%.
The diff coverage is 27.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6005      +/-   ##
==========================================
+ Coverage   60.23%   60.34%   +0.10%     
==========================================
  Files         145      145              
  Lines       18868    18793      -75     
==========================================
- Hits        11366    11340      -26     
+ Misses       7502     7453      -49     
Files Changed Coverage Δ
src/libsync/creds/httpcredentials.h 25.00% <ø> (+5.00%) ⬆️
src/libsync/networkjobs.cpp 54.63% <0.00%> (+0.21%) ⬆️
src/libsync/networkjobs.h 4.16% <ø> (ø)
src/libsync/propagatedownload.cpp 66.85% <ø> (ø)
src/libsync/theme.cpp 19.35% <ø> (-0.91%) ⬇️
src/libsync/theme.h 60.00% <ø> (ø)
src/libsync/creds/httpcredentials.cpp 20.14% <42.85%> (+2.89%) ⬆️

... and 3 files with indirect coverage changes

src/gui/wizard/owncloudwizard.cpp Outdated Show resolved Hide resolved
src/libsync/creds/httpcredentials.cpp Outdated Show resolved Hide resolved
@claucambra claucambra force-pushed the work/remove-unused-oauth-theme-values branch from f4cac50 to e097ba9 Compare September 8, 2023 05:18
Copy link
Contributor

@allexzander allexzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claucambra

Compilation still fails:
continuous-integration/drone/pr — Build is failing

@mgallien mgallien force-pushed the work/remove-unused-oauth-theme-values branch from e097ba9 to ceee1da Compare September 16, 2023 09:09
@mgallien
Copy link
Collaborator

@claucambra please fix the conflict ?

@claucambra claucambra force-pushed the work/remove-unused-oauth-theme-values branch from ceee1da to 3be0a8e Compare September 18, 2023 01:20
@claucambra
Copy link
Collaborator Author

@claucambra please fix the conflict ?

now fixed

Copy link
Member

@camilasan camilasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@mgallien mgallien force-pushed the work/remove-unused-oauth-theme-values branch from 3be0a8e to e8b4645 Compare September 18, 2023 14:06
@claucambra claucambra force-pushed the work/remove-unused-oauth-theme-values branch from e8b4645 to 6cf04d6 Compare September 19, 2023 06:58
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6005-6cf04d660b8ba7cf59c227826a0ecf718a0b0c16-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

14.3% 14.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@claucambra claucambra disabled auto-merge September 19, 2023 07:44
@claucambra claucambra merged commit 1a0a7ec into master Sep 19, 2023
11 of 13 checks passed
@claucambra claucambra deleted the work/remove-unused-oauth-theme-values branch September 19, 2023 07:44
@claucambra
Copy link
Collaborator Author

/backport to stable-3.10

@backportbot-nextcloud
Copy link

The backport to stable-3.10 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.10
git pull origin stable-3.10

# Create the new backport branch
git checkout -b fix/foo-stable-3.10

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-3.10

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dead OAuth code
5 participants