Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead OAuth code #3962

Closed
FlexW opened this issue Nov 11, 2021 · 1 comment · Fixed by #6005
Closed

Remove dead OAuth code #3962

FlexW opened this issue Nov 11, 2021 · 1 comment · Fixed by #6005
Assignees
@claucambra
Labels
bug confirmed bug approved by the team

Comments

@FlexW
Copy link

FlexW commented Nov 11, 2021

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Since OAuth is not used anymore and was replaced by Login Flow V1 and V2, it would be nice to have the code removed from the desktop client.
@tobiasKaminsky
Copy link
Member

Totally fine by me.
This can be a nice evening task to slowly remove it. Nothing time critical 👍

@claucambra claucambra self-assigned this Aug 29, 2023
@claucambra claucambra linked a pull request Aug 29, 2023 that will close this issue
Remove dead OAuth code #6005
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claucambra claucambra

Labels
bug confirmed bug approved by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dead OAuth code nextcloud/desktop
3 participants
@tobiasKaminsky @FlexW @claucambra