[MNT] Remove query-tool from repos to receive synced Docker nightly workflow #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surchs
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Thanks @alyssadai, this looks great!
I'm a bit puzzled by the diff. Maybe take another look to see if it makes sense to you, then 🧑🍳
Comment on lines
+50
to
+61
| repos: | | ||
| neurobagel/query-tool | ||
| neurobagel/api | ||
| neurobagel/bagel-cli | ||
| neurobagel/federation-api | ||
| neurobagel/tools | ||
| neurobagel/ui | ||
|
|
||
| # Workflow to build + push Docker nightly image | ||
| # NOTE: Each repo needs to have a secret with the name DOCKERHUB_REPO set up | ||
| # which refers to the DockerHub repository name | ||
| - files: |
There was a problem hiding this comment.
why does this diff look so odd? Did we have a workflow that handled both SEMVER docker and nightly docker builds?
There was a problem hiding this comment.
yes, in:
we started syncing the workflow for building nightly Docker images, but we did so by adding that workflow to the same existing sync group as the SEMVER Docker images.
In this PR we split those two wfs into separate sync groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Checklist
This section is for the PR reviewer
[ENH],[FIX],[REF],[TST],[CI],[MNT],[INF],[MODEL],[DOC]) (see our Contributing Guidelines for more info)Closes #XXXXFor new features:
For bug fixes: