Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔄 synced file(s) with neurobagel/workflows #407

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

neurobagel-bot[bot]
Copy link
Contributor

@neurobagel-bot neurobagel-bot bot commented Dec 18, 2024

synced local file(s) with neurobagel/workflows.

Changed files
  • synced local .autorc with remote template_configs/.autorc

This PR was created automatically by the repo-file-sync-action workflow run #12644813733

@neurobagel-bot neurobagel-bot bot added the _bot [BOT only] Issue or PR made by a bot. label Dec 18, 2024
Copy link

sourcery-ai bot commented Dec 18, 2024

Reviewer's Guide by Sourcery

This PR synchronizes configuration files with the neurobagel/workflows repository. The main changes involve removing the commit SHA fetching and package.json version update steps from the Docker nightly build workflow.

Sequence diagram for Docker nightly build workflow

sequenceDiagram
    participant GitHubActions as GitHub Actions
    participant DockerHub as Docker Hub
    participant Repo as Repository

    GitHubActions->>Repo: Checkout code
    GitHubActions->>DockerHub: Login to Docker Hub
    Note over GitHubActions: Removed steps:
    GitHubActions--xRepo: Fetch latest commit SHA
    GitHubActions--xRepo: Update package.json version

    GitHubActions->>DockerHub: Build and push Docker image
Loading

File-Level Changes

Change Details Files
Simplified Docker nightly build workflow by removing commit SHA and version update steps
  • Removed step that fetches the latest commit SHA from main branch
  • Removed step that updates package.json version with the commit SHA
.github/workflows/build_docker_nightly.yml
Synchronized configuration files with template repository
  • Updated .autorc file to match template configuration
.autorc

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit cf07c2b
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/677ca37372f63f0008ff1a9b
😎 Deploy Preview https://deploy-preview-407--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs added the flag:discuss Flag issue that needs to be discussed before it can be implemented. label Dec 20, 2024
@surchs
Copy link
Contributor

surchs commented Dec 20, 2024

@rmanaem this PR is trying to undo all our nice GH workflow changes again. I guess we need to take the query tool out of our synced docker nightly build flow

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't undo the docker nightly changes

@surchs
Copy link
Contributor

surchs commented Dec 20, 2024

We will

  • remove docker nightly from sync and add comment that query tool is doing own docker nightly
  • close this PR
  • wait for sync to make new PR

@neurobagel-bot neurobagel-bot bot force-pushed the repo-sync/workflows/default branch from 5410837 to cf07c2b Compare January 7, 2025 03:45
@alyssadai
Copy link
Contributor

@surchs, it looks like the bot was clever enough to update this PR after neurobagel/workflows#121 so it's no longer trying to modify the nightly Docker workflow 👍

Want to take another look & approve/merge if all looks good?

@surchs surchs merged commit 9bd09fc into main Jan 7, 2025
12 checks passed
@surchs surchs deleted the repo-sync/workflows/default branch January 7, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_bot [BOT only] Issue or PR made by a bot. flag:discuss Flag issue that needs to be discussed before it can be implemented.
Projects
Status: Review - Done
Development

Successfully merging this pull request may close these issues.

2 participants