-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fix deploy workflow #412
Conversation
Appzi and plausible script were not correctly inserted
Reviewer's Guide by SourceryThis pull request fixes the deployment workflow by correctly inserting the Appzi and Plausible scripts into the Sequence diagram for the deployment workflow script insertionsequenceDiagram
participant D as Deploy Workflow
participant H as index.html
D->>H: Read file content
Note over D: Prepare single-line script tags
D->>H: Insert Appzi and Plausible scripts
Note over H: Scripts properly embedded
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Deploy Preview for neurobagel-query ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- correct WF invocation of sed - remove dangling appzi scripts in index.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧑🍳
Don't forget a PR label @surchs! |
🚀 PR was released in |
Appzi and plausible script were not correctly inserted. This caused https://github.com/neurobagel/query-tool/actions/runs/12415438011/job/34661801769 to break
Changes proposed in this pull request:
NOTE: If this pull request is to be released, the release label must be applied once the review process is done to avoid the local and remote from going out of sync as a consequence of the
bump version
workflow runChecklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
query-tool-results
files in the neurobagel_examples repo have been regeneratedFor new features:
For bug fixes:
Summary by Sourcery
Fix the deployment workflow to correctly insert the Appzi and Plausible scripts into the index.html file.
CI:
Deployment: