-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Refined content and location of How to access data
button
#409
Conversation
Reviewer's Guide by SourceryThis PR refines the user interface by relocating the "How to access data" button from the results container to the query form and improving its content. The changes aim to make data access instructions more accessible and clearer to users. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Deploy Preview for neurobagel-query ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rmanaem, this looks great!
I guess in the future we could also get the "download results" button to sit on the same vertical level with "submit query" and "how to get data".
Also: I think we should release off this PR already so we get the fix in #412 deployed - because I forgot to do that.
🧑🍳
agreed |
🚀 PR was released in |
NOTE: If this pull request is to be released, the release label must be applied once the review process is done to avoid the local and remote from going out of sync as a consequence of the
bump version
workflow runChecklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
query-tool-results
files in the neurobagel_examples repo have been regeneratedFor new features:
For bug fixes:
Summary by Sourcery
Refine the content and location of the 'How to access data' button in the QueryForm component and update the corresponding test to ensure the dialog opens correctly.
Enhancements:
Tests: