-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Enabled functionality to remove unmapped assessment tools and columns #833
Conversation
Reviewer's Guide by SourceryThis PR implements functionality to remove unmapped assessment tools and columns, enhances the search filtering in dropdowns, and adds a restart annotation feature. The changes primarily focus on UI improvements and state management modifications. Sequence diagram for removing an assessment toolsequenceDiagram
participant User
participant UI
participant Store
User ->> UI: Click 'Remove' button for tool
UI ->> Store: deselectTool(tool.identifier)
Store -->> UI: Update tool selection state
UI -->> User: Tool removed from selection
Sequence diagram for restarting annotationsequenceDiagram
participant User
participant UI
participant Store
User ->> UI: Click 'Annotate Another Dataset' button
UI ->> Store: resetState()
Store -->> UI: State reset
UI ->> Store: navigateToPage('home')
Store -->> UI: Navigate to home page
UI -->> User: Redirect to home page
Class diagram for updated Vuex store mutationsclassDiagram
class Store {
+createAssessmentTool()
+alterColumnToToolMapping()
+alterColumnCategoryMapping()
+deselectTool()
+resetState()
}
class Tool {
+identifier
+selected
}
Store --> Tool : manages
note for Store "New mutations added: deselectTool, resetState"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Deploy Preview for neurobagel-annotator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmanaem - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the duplicated filterOptions function from category-toolgroup.vue and annot-categorical.vue into a shared utility function to avoid code duplication
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool stuff 🎉
🧑🍳
Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)Closes #XXXX
For new features:
For bug fixes:
Summary by Sourcery
Enable the removal of unmapped assessment tools and columns in the UI, enhance search functionality with a custom filter for v-select components, and refactor the Vuex store for better state management.
New Features:
Enhancements:
Chores: