-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Addressed the issue with missing mutations #837
Conversation
Reviewer's Guide by SourceryThis PR restores previously overwritten mutations by adding back the Class diagram for Vuex store mutationsclassDiagram
class Store {
+createAssessmentTool()
+alterColumnToToolMapping()
+alterColumnCategoryMapping()
+deselectTool(p_state, toolIdentifier)
}
note for Store "The `deselectTool` mutation was added back to the store."
Class diagram for category-toolgroup componentclassDiagram
class CategoryToolGroup {
+createAssessmentTool()
+alterColumnToToolMapping()
+alterColumnCategoryMapping()
+deselectTool()
}
note for CategoryToolGroup "The `deselectTool` and `alterColumnCategoryMapping` mutations were added to the component."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Deploy Preview for neurobagel-annotator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch @rmanaem !
🧑🍳
During the review of #836, I noticed certain changes made in #833 were overwritten during the daisy chain merge. This PR aims to address what was overwritten and left out of that PR.
Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)Closes #XXXX
For new features:
For bug fixes:
Summary by Sourcery
Restore missing mutations that were overwritten in a previous merge, including implementing 'deselectTool' and adding 'alterColumnCategoryMapping' to improve tool and category management.
New Features:
Enhancements: