Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Addressed the issue with missing mutations #837

Merged
merged 2 commits into from
Dec 19, 2024
Merged

[FIX] Addressed the issue with missing mutations #837

merged 2 commits into from
Dec 19, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Dec 18, 2024

During the review of #836, I noticed certain changes made in #833 were overwritten during the daisy chain merge. This PR aims to address what was overwritten and left out of that PR.

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Summary by Sourcery

Restore missing mutations that were overwritten in a previous merge, including implementing 'deselectTool' and adding 'alterColumnCategoryMapping' to improve tool and category management.

New Features:

  • Implement the 'deselectTool' mutation to allow tools to be deselected.

Enhancements:

  • Add 'alterColumnCategoryMapping' mutation to enhance column category mapping capabilities.

Copy link

sourcery-ai bot commented Dec 18, 2024

Reviewer's Guide by Sourcery

This PR restores previously overwritten mutations by adding back the deselectTool mutation to the Vuex store and importing additional mutation methods in the category-toolgroup component.

Class diagram for Vuex store mutations

classDiagram
    class Store {
        +createAssessmentTool()
        +alterColumnToToolMapping()
        +alterColumnCategoryMapping()
        +deselectTool(p_state, toolIdentifier)
    }
    note for Store "The `deselectTool` mutation was added back to the store."
Loading

Class diagram for category-toolgroup component

classDiagram
    class CategoryToolGroup {
        +createAssessmentTool()
        +alterColumnToToolMapping()
        +alterColumnCategoryMapping()
        +deselectTool()
    }
    note for CategoryToolGroup "The `deselectTool` and `alterColumnCategoryMapping` mutations were added to the component."
Loading

File-Level Changes

Change Details Files
Added new Vuex mutation for deselecting tools
  • Implemented deselectTool mutation that sets a tool's selected state to false based on its identifier
  • Added mutation to the store's mutation object
store/index.js
Updated component mutation mappings
  • Added mapping for alterColumnCategoryMapping mutation
  • Added mapping for deselectTool mutation
components/category-toolgroup.vue

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@rmanaem rmanaem changed the title [FImported and implemented missing mutations [FIX] imported and implemented missing mutations Dec 18, 2024
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for neurobagel-annotator ready!

Name Link
🔨 Latest commit 5d9141c
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-annotator/deploys/67638a434813bc0008be1753
😎 Deploy Preview https://deploy-preview-837--neurobagel-annotator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmanaem rmanaem changed the title [FIX] imported and implemented missing mutations [FIX] Addressed the issue with missing mutations Dec 18, 2024
@rmanaem rmanaem requested a review from surchs December 18, 2024 07:55
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @rmanaem !

🧑‍🍳

@surchs surchs mentioned this pull request Dec 18, 2024
2 tasks
@rmanaem rmanaem merged commit b879f3b into main Dec 19, 2024
9 checks passed
@rmanaem rmanaem deleted the fix branch December 19, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review - Done
Development

Successfully merging this pull request may close these issues.

2 participants