Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Aligned assessment tool workflow UI elements #622

Merged
merged 3 commits into from
Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/category-select-table.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

<div>

<b-row class="no-padding-row">
<b-row>
rmanaem marked this conversation as resolved.
Show resolved Hide resolved

<b-col cols="12" class="no-padding-col">
<b-col cols="12">
<b-table
outlined
selectable
Expand Down
52 changes: 28 additions & 24 deletions components/category-toolgroup.vue
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
<template>
<div>
<b-row>
<b-col cols="6">
<b-row>
<b-col cols="4">
<b-row>
<v-select
v-if="tableRows.length > 0"
data-cy="toolgroup-select"
:options="toolTerms"
outlined
@input="selectTool"
:selectable="(option) => !getSelectedTools.some(el => el.identifier.includes(option.identifier))" />
</b-col>
</b-row>
<b-row>
<b-col>
:selectable="(option) => !getSelectedTools.some(el => el.identifier.includes(option.identifier))"
class="aligned-element" />
</b-row>
<b-row>
<b-table
v-if="getSelectedTools.length > 0"
data-cy="assessment-tool-table"
Expand All @@ -26,22 +25,21 @@
@row-selected="highlightRow"
:tbody-tr-class="styleTableRow"
thead-class="hidden" />

</b-col>
<b-col>
<b-table
v-if="tableRows.length > 0"
data-cy="assessment-column-table"
outlined
head-variant="dark"
:items="tableRows"
selected-variant=""
thead-class="hidden"
@row-clicked="mapColumn"
:tbody-tr-class="styleRow" />
</b-col>
</b-row>
</div>
</b-row>
</b-col>
<b-col cols="8" class="margin-top">
<b-table
v-if="tableRows.length > 0"
data-cy="assessment-column-table"
outlined
head-variant="dark"
:items="tableRows"
selected-variant=""
thead-class="hidden"
@row-clicked="mapColumn"
:tbody-tr-class="styleRow" />
</b-col>
</b-row>
</template>

<script>
Expand Down Expand Up @@ -123,5 +121,11 @@
.selected-tool {
background-color: red !important;
}
.margin-top {
margin-top: 66px;
}
.aligned-element {
flex: 1;
}

</style>
2 changes: 2 additions & 0 deletions cypress.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ const fs = require("fs");
module.exports = defineConfig({

e2e: {
viewportHeight: 1080,
viewportWidth: 1920,

baseUrl: "http://localhost:3000",

Expand Down
6 changes: 1 addition & 5 deletions cypress/e2e/app/simple-e2etest.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,7 @@ describe("End to end test using a simple UI path through the app", () => {
];

beforeEach(() => {

// Standard setup for annotation tool testing
cy.appSetup();

// 2. Open the index page
// 1. Open the index page
cy.visit("/");
});

Expand Down
6 changes: 0 additions & 6 deletions cypress/e2e/page/annotation-pagetests.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@ describe("tests on annotation page ui with programmatic state loading and store
// NOTE: Add more dataset json files here via 'require'
];

beforeEach(() => {

// Standard app setup
cy.appSetup();
});

datasets.forEach((p_dataset) => {

context("Annotation page tests with " + p_dataset.description + " data", () => {
Expand Down
6 changes: 0 additions & 6 deletions cypress/e2e/page/categorization-pagetests.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@ describe("Tests on categorization page ui via programmatic state loading and sto
// NOTE: Add more dataset json files here via 'require'
];

beforeEach(() => {

// Standard app setup
cy.appSetup();
});

datasets.forEach((p_dataset) => {

context("Categorization page tests with " + p_dataset.description + " data", () => {
Expand Down
6 changes: 0 additions & 6 deletions cypress/e2e/page/download-pagetests.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@ describe("tests on download page ui via programmatic state loading and store int
// NOTE: Add more dataset json files here via 'require'
];

beforeEach(() => {

// Standard app setup
cy.appSetup();
});

datasets.forEach((p_dataset) => {

context("download page tests with " + p_dataset.description + " data", () => {
Expand Down
6 changes: 0 additions & 6 deletions cypress/e2e/page/index-pagetests.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,6 @@ describe("Tests on the index page via store interaction", () => {
// NOTE: Add more dataset json files here via 'require'
];

beforeEach(() => {

// Standard app setup
cy.appSetup();
});

datasets.forEach((p_dataset) => {

context("index page with " + p_dataset.description + " data", () => {
Expand Down
10 changes: 0 additions & 10 deletions cypress/support/commands.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,6 @@

// Standard setup functionality for each collection of tests
// NOTE: In the future we will likely want to parametrize this for different
// test setups (i.e. testing across different viewport sizes).
Cypress.Commands.add("appSetup", () => {

// Standard setup for annotation tool testing

// A. Set viewport size
// NOTE: Standard 13-inch laptop screen to start, but this can be expanded
cy.viewport("macbook-13");
});

rmanaem marked this conversation as resolved.
Show resolved Hide resolved
Cypress.Commands.add("assertButtonStatus", (p_buttonName, p_enabled) => {

let chainer = ( p_enabled ) ? "not.have.class" : "have.class";
Expand Down
6 changes: 1 addition & 5 deletions pages/categorization.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,7 @@
</b-col>

</b-row>
<b-row>
<b-col cols="12">
<categoryToolgroup />
</b-col>
</b-row>
<categoryToolgroup />

</b-container>

Expand Down
1 change: 0 additions & 1 deletion test_contributions.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ TBD
- `context` is a container function used to group different kinds of tests within the file and also is used to describe that context
- `it` defines the individual, specific test you are writing
*3.* Both `describe` and `context` can contain `beforeEach` functions that will be run before every `context` or before every `it`, respectively
- Use the `appSetup` function in your `beforeEach` for the `describe` function. This calls a set of common app configuration commands.
*4.* Writing individual tests
- Tests contain three primary sections: setup, action, and assert. They can be repeated as needed depending on the complexity of the test. But a good guideline to follow is to keep tests as simople as possible.
- It is possible to work with multiple datasets for one test file. The paradigm that has been setup can be seen, for example, in `annotation-pagetests.cy.js`. The idea is that you utilize json files in the `fixtures` folder that describe each dataset and can use functions `datasetMeetsTestCriteria` and `loadAppState` to reflect both the data needs of your test and the dataset that's being used for the test.
Expand Down
Loading