Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Aligned assessment tool workflow UI elements #622

Merged
merged 3 commits into from
Nov 10, 2023
Merged

[ENH] Aligned assessment tool workflow UI elements #622

merged 3 commits into from
Nov 10, 2023

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Nov 9, 2023 •
edited by surchs
Loading

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@surchs
Copy link
Contributor

surchs commented Nov 9, 2023

Shouldn't there be a preview build from netlify here?

surchs
surchs approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳 looks good @rmanaem 🎉. I even tried playing with the viewport size and it works great - at least as good as the rest of the app.

cypress/e2e/app/simple-e2etest.cy.js Outdated Show resolved Hide resolved
cypress/support/commands.js Show resolved Hide resolved
components/category-select-table.vue Show resolved Hide resolved
@netlify Netlify
Copy link

netlify bot commented Nov 10, 2023 •
edited
Loading

✅ Deploy Preview for neurobagel-annotator ready!

Name Link
🔨 Latest commit dd70b1b
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-annotator/deploys/654e73dd41d94f0008ba4853
😎 Deploy Preview https://deploy-preview-622--neurobagel-annotator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmanaem rmanaem merged commit a5f85a9 into main Nov 10, 2023
7 checks passed
@rmanaem rmanaem deleted the feat-612 branch November 10, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The assessment tool workflow is horizontally aligned below the column workflow
2 participants
@rmanaem @surchs