Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: min version should be lowest version of 18, not the latest #6110

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

ericapisani
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #<replace_with_issue_number>


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@ericapisani ericapisani requested a review from a team as a code owner November 1, 2023 14:30
Copy link

github-actions bot commented Nov 1, 2023

📊 Benchmark results

Comparing with 00e8d9d

  • Dependency count: 1,373 (no change)
  • Package size: 381 MB (no change)

@ericapisani ericapisani added the automerge Add to Kodiak auto merge queue label Nov 1, 2023
@ericapisani ericapisani merged commit e770302 into main Nov 1, 2023
@ericapisani ericapisani deleted the ep/change-min-version branch November 1, 2023 15:03
ericapisani added a commit that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants