Skip to content

Commit

Permalink
fix: min version should be lowest version of 18, not the latest (#6110)
Browse files Browse the repository at this point in the history
  • Loading branch information
ericapisani authored Nov 1, 2023
1 parent 00e8d9d commit e770302
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
#
# os: [ubuntu-latest, macOS-latest, windows-latest]
os: [ubuntu-latest, macOS-latest]
node-version: ['18.18.2', '*']
node-version: ['18.0.0', '*']
fail-fast: false

steps:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
node-version: ['18.18.2', '*']
node-version: ['18.0.0', '*']
shard: ['1/3', '2/3', '3/3']

exclude:
- os: macOS-latest
node-version: '18.18.2'
node-version: '18.0.0'
- os: windows-latest
node-version: '18.18.2'
node-version: '18.0.0'
fail-fast: false
steps:
# Sets an output parameter if this is a release PR
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/legacy-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
node-version: ['18.18.2', '*']
node-version: ['18.0.0', '*']
machine: ['0', '1', '2', '3', '4', '5', '6']

exclude:
- os: macOS-latest
node-version: '18.18.2'
node-version: '18.0.0'
- os: windows-latest
node-version: '18.18.2'
node-version: '18.0.0'
fail-fast: false
steps:
# Sets an output parameter if this is a release PR
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
node-version: ['18.18.2', '*']
node-version: ['18.0.0', '*']
fail-fast: false
steps:
# Sets an output parameter if this is a release PR
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"author": "Netlify Inc.",
"type": "module",
"engines": {
"node": ">=18.18.2"
"node": ">=18.0.0"
},
"files": [
"/bin",
Expand Down

2 comments on commit e770302

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Benchmark results

  • Dependency count: 1,373
  • Package size: 381 MB

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Benchmark results

  • Dependency count: 1,373
  • Package size: 381 MB

Please sign in to comment.