fix: stop using snapshot for checking invalid package json #5313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
khendrikse
force-pushed
the
fix/fix-snapshot-for-invalid-package-json
branch
from
d6139ba to
1564e86
Compare
eduardoboucas
previously approved these changes
Oct 6, 2023
eduardoboucas
previously approved these changes
Oct 6, 2023
khendrikse
force-pushed
the
fix/fix-snapshot-for-invalid-package-json
branch
from
d2cf3a2 to
27a4618
Compare
|
I'm seeing that this one is getting stuck, and I am unsure how to fix it: https://github.com/netlify/build/actions/runs/6430875918/job/17462666876?pr=5313 Maybe @eduardoboucas knows? |
lukasholzer
previously approved these changes
Oct 6, 2023
estephinson
approved these changes
Oct 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
We have a failing snapshot test, probably due to a change in node versions. I decided to change the test to check if we're getting a configuration error instead.
Hoping to get this merged soon, I see a lot of PR's are blocked because of this.
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)