fix: stop using snapshot for checking invalid package json

netlify · Oct 6, 2023 · d6139ba · d6139ba
1 parent 6f84bd6
commit d6139ba
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 53 deletions.
diff --git a/packages/build/tests/functions/snapshots/tests.js.md b/packages/build/tests/functions/snapshots/tests.js.md
@@ -283,58 +283,6 @@ Generated by [AVA](https://avajs.dev).
     (Netlify Build completed in 1ms)␊
     Build step duration: Netlify Build completed in 1ms`
 
-## Functions: invalid package.json
-
-> Snapshot 1
-
-    `␊
-    Netlify Build                                                 ␊
-    ────────────────────────────────────────────────────────────────␊
-    ␊
-    > Version␊
-      @netlify/build 1.0.0␊
-    ␊
-    > Flags␊
-      debug: true␊
-      repositoryRoot: packages/build/tests/functions/fixtures/functions_package_json_invalid␊
-      testOpts:␊
-        pluginsListUrl: test␊
-        silentLingeringProcesses: true␊
-    ␊
-    > Current directory␊
-      packages/build/tests/functions/fixtures/functions_package_json_invalid␊
-    ␊
-    > Config file␊
-      packages/build/tests/functions/fixtures/functions_package_json_invalid/netlify.toml␊
-    ␊
-    > Resolved config␊
-      build:␊
-        publish: packages/build/tests/functions/fixtures/functions_package_json_invalid␊
-        publishOrigin: default␊
-      functionsDirectory: packages/build/tests/functions/fixtures/functions_package_json_invalid/functions␊
-    ␊
-    > Context␊
-      production␊
-    ␊
-    Functions bundling                                            ␊
-    ────────────────────────────────────────────────────────────────␊
-    ␊
-    Packaging Functions from functions directory:␊
-     - test.js␊
-    ␊
-    ␊
-    Configuration error                                           ␊
-    ────────────────────────────────────────────────────────────────␊
-    ␊
-      Error message␊
-      Unexpected token { in JSON at position 1␊
-    ␊
-      Resolved config␊
-      build:␊
-        publish: packages/build/tests/functions/fixtures/functions_package_json_invalid␊
-        publishOrigin: default␊
-      functionsDirectory: packages/build/tests/functions/fixtures/functions_package_json_invalid/functions`
-
 ## Functions: --functionsDistDir
 
 > Snapshot 1

diff --git a/packages/build/tests/functions/snapshots/tests.js.snap b/packages/build/tests/functions/snapshots/tests.js.snap
diff --git a/packages/build/tests/functions/tests.js b/packages/build/tests/functions/tests.js
@@ -45,7 +45,7 @@ test('Functions: invalid package.json', async (t) => {
   await writeFile(packageJsonPath, '{{}')
   try {
     const output = await new Fixture('./fixtures/functions_package_json_invalid').runWithBuild()
-    t.snapshot(normalizeOutput(output))
+    t.true(output.includes('Configuration error'))
   } finally {
     await rm(packageJsonPath, { force: true, recursive: true, maxRetries: 10 })
   }