Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't detect Redwood App as multiple workspaces #5271

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Sep 1, 2023

Summary

@thedavidprice reported an issue with how Netlify detects Redwood apps. Since a Redwood app is implemented as a Yarn Workspace, we detect it as being multiple apps api and web - while in reality, it should be one app.

This PR fixes our detection mechanism, by implementing an edge case for Redwood apps. We do this by matching on the redwood.toml file.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@Skn0tt Skn0tt self-assigned this Sep 1, 2023
minivan
minivan previously approved these changes Sep 1, 2023
@Skn0tt Skn0tt marked this pull request as ready for review September 1, 2023 10:06
@Skn0tt Skn0tt requested review from a team as code owners September 1, 2023 10:06
@Skn0tt Skn0tt merged commit 9eaa059 into main Sep 1, 2023
30 checks passed
@Skn0tt Skn0tt deleted the workspace-detection-redwood-edge-case branch September 1, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants