fix: webFS#fileExists needs to await file check

netlify · Sep 1, 2023 · 5d34ed2 · 5d34ed2
1 parent 9726ed2
commit 5d34ed2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/packages/build-info/src/browser/file-system.ts b/packages/build-info/src/browser/file-system.ts
@@ -26,7 +26,7 @@ export class GithubProvider {
     if (response.headers?.get('Content-Type')?.match(/json/)) {
       const json = await response.json()
       if (!response.ok) {
-        Promise.reject(json)
+        throw new Error(JSON.stringify(json))
       }
       return json
     }
@@ -55,7 +55,7 @@ export class WebFS extends FileSystem {
 
   async fileExists(path: string): Promise<boolean> {
     try {
-      this.readFile(path)
+      await this.readFile(path)
       return true
     } catch {
       return false

diff --git a/packages/build-info/tests/helpers.ts b/packages/build-info/tests/helpers.ts
@@ -68,16 +68,11 @@ export const createWebFixture = async (fixture: string) => {
       const info = await stat(src)
       if (info.isDirectory()) {
         const entries = await readdir(src, { withFileTypes: true })
-        return new Response(
-          JSON.stringify(
-            entries.map((entry) => ({
-              path: entry.name,
-              type: entry.isDirectory() ? 'dir' : 'file',
-            })),
-          ),
-          {
-            headers: { 'Content-Type': 'application/json' },
-          },
+        return Response.json(
+          entries.map((entry) => ({
+            path: entry.name,
+            type: entry.isDirectory() ? 'dir' : 'file',
+          })),
         )
       } else {
         const file = await readFile(src, 'utf-8')
@@ -87,7 +82,7 @@ export const createWebFixture = async (fixture: string) => {
       // noop
     }
 
-    throw new Error(`404 ${url} not found!`)
+    return Response.json({ error: 'not found' }, { status: 404 })
   })
 
   return { cwd: '/' }