Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

chore: remove code duplication in custom Node.js version logic #757

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Mar 8, 2022

This is the first part to solving #748

This PR removes some code duplication. It does not change the logic.

Manual tests in production here and there.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update the included software doc (if you updated included software) 📄
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Mar 8, 2022
@ehmicky ehmicky requested review from JGAntunes, lukasholzer, erezrokah and a team March 8, 2022 16:12
@ehmicky ehmicky self-assigned this Mar 8, 2022
@kodiakhq kodiakhq bot merged commit 7335e6b into focal Mar 24, 2022
@kodiakhq kodiakhq bot deleted the chore/refactor-custom-node branch March 24, 2022 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants