Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

chore: remove code duplication in custom Node.js version logic (Xenial) #758

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Mar 8, 2022

Same PR as #757 but for Xenial.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update the included software doc (if you updated included software) πŸ“„
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Mar 8, 2022
@ehmicky ehmicky requested review from JGAntunes, lukasholzer, erezrokah and a team March 8, 2022 17:21
@ehmicky ehmicky self-assigned this Mar 8, 2022
@ehmicky ehmicky changed the base branch from focal to xenial March 8, 2022 17:23
@kodiakhq kodiakhq bot merged commit 385a36f into xenial Mar 24, 2022
@kodiakhq kodiakhq bot deleted the chore/refactor-custom-node-xenial branch March 24, 2022 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants