Make end-to-end tests work with a local porch-server #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamfallon
reviewed
May 31, 2024
|
NOTE: I've added instructions to run the end-to-end tests to the description of the PR. |
- start with clean etcd for local tests - make some problematic test cases more verbose (and faster) - handle the new testing scenario, when everything is running in-cluster, but the porch-server (that is running locally)
… Deployment resource, as opposed to all resources in the 9-controllers.yaml file
…running in-cluster or not
…ing out-of-cluster
…h the go-client module
nagygergo
reviewed
Jun 3, 2024
nagygergo
reviewed
Jun 3, 2024
nagygergo
reviewed
Jun 3, 2024
nagygergo
reviewed
Jun 3, 2024
nagygergo
reviewed
Jun 3, 2024
nagygergo
reviewed
Jun 3, 2024
nagygergo
reviewed
Jun 3, 2024
nagygergo
reviewed
Jun 3, 2024
Co-authored-by: Gergely Nagy <[email protected]>
|
/approve |
|
/retest |
|
/test presubmit-nephio-go-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kispaljr, liamfallon, nagygergo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now some end-to-end test cases fail if the porch-server is running locally and not in-cluster. (The same tests are working properly, if all components are running in-cluster)
This PR intends to fix this problem.
Fixes nephio-project/nephio#743
End-to-end test can be run with the following commands:
The above commands should all succeed with the code in this PR.
This PR is based on the loosely related #44