Make PackageRevision's metadata.uid field unique #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kispaljr
requested review from
tliron,
johnbelamaric,
liamfallon and
efiacor
and removed request for
s3wong and
henderiw
kispaljr
force-pushed
the
unique-id-for-pkg-rev
branch
from
51cbca8 to
a8f2454
Compare
kispaljr
force-pushed
the
unique-id-for-pkg-rev
branch
from
3be7481 to
2f6bfdd
Compare
|
/retest |
|
/retest |
liamfallon
reviewed
Jun 20, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kispaljr, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .metadata.uid field of PackageRevisions are simply created from the name and revision of the package. It is not unique in the whole cluster, because it doesn't contain the name of the registry or the namespace.
Fixes nephio-project/nephio#748
Based on #57