Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update capi pkg to v1.8.1 #80

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Update capi pkg to v1.8.1 #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,692 changes: 1,156 additions & 536 deletions infra/capi/cluster-capi-infrastructure-docker/cluster-api-infrastructure-docker.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions infra/capi/cluster-capi-kind/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ The package contains some defaults but can be changed through the kpt pipeline
- pod cidrBlocks: 192.168.0.0/16
- service cidrBlocks: 10.128.0.0/12
- service domain: cluster.local
- kubernetes version: v1.26.3
- workers: 3
- kubernetes version: v1.31.0
- workers: 1
2 changes: 1 addition & 1 deletion infra/capi/cluster-capi-kind/cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
enabled: true
enforce: baseline
warn: restricted
version: v1.26.3
version: v1.31.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not just updating the kptfile help rather than updating the actual files every time?I could be wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few changes to the whole pkg so I don't think so. Changes to the CRDs etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI It seems like we should be using something like the link below for changing image names and tags
https://catalog.kpt.dev/set-image/v0.1/set-image-simple/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would somewhat agree but this is the base k8s version to be used in the workload clusters.
We could look to set this value dynamically later if needed but for now I am just updating the base version of each 3pp component.

workers:
machineDeployments:
- class: docker-default-worker
Expand Down
Loading